Sorter: Extract validation out of scoring

[Myranae]

Summary:

To complete server-side scoring, we are separating out validation logic from scoring logic. This separates that logic for the sorter widget and updates associated tests.

Issue: LEMS-2605

Test plan:

• Confirm all checks pass
• Confirm widget still works as expected via Storybook

[github-actions]

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (61de24e) and published it to npm. You
can install it using the tag PR1876.

Example:

yarn add @khanacademy/perseus@PR1876

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1876

[github-actions]

Size Change: +157 B (+0.01%)

Total Size: 1.29 MB

Filename	Size	Change
packages/perseus/dist/es/index.js	421 kB	+157 B (+0.04%)

ℹ️ View Unchanged

Filename	Size
packages/kas/dist/es/index.js	39 kB
packages/keypad-context/dist/es/index.js	760 B
packages/kmath/dist/es/index.js	4.27 kB
packages/math-input/dist/es/index.js	77.9 kB
packages/math-input/dist/es/strings.js	1.79 kB
packages/perseus-core/dist/es/index.js	1.48 kB
packages/perseus-editor/dist/es/index.js	698 kB
packages/perseus-linter/dist/es/index.js	22.2 kB
packages/perseus/dist/es/strings.js	3.68 kB
packages/pure-markdown/dist/es/index.js	3.66 kB
packages/simple-markdown/dist/es/index.js	12.5 kB

_{compressed-size-action}

[khan-actions-bot]

Gerald

Required Reviewers

• @Khan/perseus for changes to .changeset/sweet-trainers-drop.md, packages/perseus/src/widgets/sorter/score-sorter.test.ts, packages/perseus/src/widgets/sorter/score-sorter.ts, packages/perseus/src/widgets/sorter/validate-sorter.test.ts, packages/perseus/src/widgets/sorter/validate-sorter.ts

---

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

[jeremywiebe]

I think we could keep a variant of this test in each scorer's test suite. But, we can use mocking to ensure that validate is called first... something like:

I think we could keep a variant of this test in each scorer's test suite. But, we can use mocking to ensure that validate is called first... something like:

// Top of file 
import * as SorterValidator from './validate-sorter'

    // Inside describe() block...
    it("should score if validator passes", () => {
        // Mock validator saying "all good" 👍 
        const mockValidate = jest
            .spyOn(SorterValidator, "default")
            .mockReturnValue(null);


        const score = scoreSorter(userInput, rubric);

        // Assert
        expect(mockValidate).toHaveBeenCalled();
        expect(score).toHaveBeenAnsweredCorrectly();
    });

    it("should abort if validator returns invalid", () => {
        // Mock validator saying "all good" 👍 
        const mockValidate = jest
            .spyOn(SorterValidator, "default")
            .mockReturnValue({type: "invalid", message: null});

        const score = scoreSorter(userInput, rubric);

        // Assert
        expect(mockValidate).toHaveBeenCalled();
        expect(score).toHaveInvalidInput()
    });

[Myranae]

@jeremywiebe Do the below added tests look as expected? Thanks!

[jeremywiebe]

Yes, this looks correct! Thanks for adding these!

Matthew has an idea to refactor the scoring so that we don't have to guarantee the scorer calls validation first: https://khanacademy.atlassian.net/browse/LEMS-2658

But for now, let's leave these tests and logic in place.