Merge pull request #240 from SamCosta1/feature/bump-kcef-version

Bump the KCEF dependency version
KevinnZou · Oct 23, 2024 · fa9e47a · fa9e47a
2 parents 63ec14f + 9b154fa
commit fa9e47a
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/sample/desktopApp/src/jvmMain/kotlin/main.kt b/sample/desktopApp/src/jvmMain/kotlin/main.kt
@@ -32,7 +32,12 @@ fun main() =
                                 initialized = true
                             }
                         }
-                        release("jbr-release-17.0.10b1087.23")
+                        download {
+                            github {
+                                release("jbr-release-17.0.12b1207.37")
+                            }
+                        }
+
                         settings {
                             cachePath = File("cache").absolutePath
                         }

diff --git a/webview/build.gradle.kts b/webview/build.gradle.kts
@@ -64,7 +64,7 @@ kotlin {
         val desktopMain by getting {
             dependencies {
                 implementation(compose.desktop.common)
-                api("dev.datlag:kcef:2024.01.07.1")
+                api("dev.datlag:kcef:2024.04.20.3")
                 implementation("org.jetbrains.kotlinx:kotlinx-coroutines-swing:$coroutinesVersion")
             }
         }

diff --git a/webview/src/desktopMain/kotlin/com/multiplatform/webview/web/WebEngineExt.kt b/webview/src/desktopMain/kotlin/com/multiplatform/webview/web/WebEngineExt.kt
@@ -51,6 +51,13 @@ internal fun CefBrowser.addDisplayHandler(state: WebViewState) {
                 state.pageTitle = title
             }
 
+            override fun onFullscreenModeChange(
+                p0: CefBrowser?,
+                p1: Boolean,
+            ) {
+                // Not supported
+            }
+
             override fun onTooltip(
                 browser: CefBrowser?,
                 text: String?,