Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : 20241012_API-cancelled-문제-해결하기 #95

Conversation

godhyzzang
Copy link
Contributor

No description provided.

@godhyzzang godhyzzang requested a review from chan99k as a code owner October 12, 2024 07:37
Copy link
Contributor

@tonyfromundefined tonyfromundefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

재밌게 읽었습니다~ Form 쪽 동작은 웹 개발자가 꼭 이해해야하는 내용이니 이에 대해서 좀 더 탐구해보고 해당 내용을 추가해도 좋을거같아요.

Comment on lines 22 to 24
<img src="/Users/hayeon/Downloads/마이네임안바뀜.gif" alt="이름안바뀜">

<img alt="cancelled" src="![image.png](https://prod-files-secure.s3.us-west-2.amazonaws.com/1ee811a0-1243-4c1a-a362-fece1e87dc36/0af29550-d840-46b6-b948-b6d32e48c6db/image.png)"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<img src="/Users/hayeon/Downloads/마이네임안바뀜.gif" alt="이름안바뀜">
<img alt="cancelled" src="![image.png](https://prod-files-secure.s3.us-west-2.amazonaws.com/1ee811a0-1243-4c1a-a362-fece1e87dc36/0af29550-d840-46b6-b948-b6d32e48c6db/image.png)"/>
<img src="/Users/hayeon/Downloads/마이네임안바뀜.gif" alt="이름안바뀜">
<img alt="cancelled" src="![image.png](https://prod-files-secure.s3.us-west-2.amazonaws.com/1ee811a0-1243-4c1a-a362-fece1e87dc36/0af29550-d840-46b6-b948-b6d32e48c6db/image.png)"/>

실수하신거같아서 요거 수정이 필요할거같아요~

Comment on lines 102 to 103
'과연 여기서 api요청에 가해질 수 있는 외부압력은 어떤 종류의 것일까?' 조금 더 원초적인 코드 로직이 무엇인가를 살펴보면, 해당 button을 누른다는 것은 form 태그에 종속된 input의 내용을 보내는 동작을 수행하는 것입니다.
그런데 form 태그란 어떤 동작을 하고 있을까요? form이라는 태그는 button이 눌리면 브라우저를 새로고침하면서 input의 내용을 전송하려고 합니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"새로고침"이라는 용어는 잘못된거같아요. <form> 태그에 정의된 action을 수행하는 것이라고 표현하는것이 맞습니다.

@day1companyhaewooklee day1companyhaewooklee merged commit 516133c into Kernel360:main Oct 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants