Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 20241011_OpenAPI_TypeScript_윤예진 #91

Merged
merged 3 commits into from
Oct 21, 2024
Merged

feat: 20241011_OpenAPI_TypeScript_윤예진 #91

merged 3 commits into from
Oct 21, 2024

Conversation

Yejin0O0
Copy link
Contributor

No description provided.

@Yejin0O0 Yejin0O0 requested a review from chan99k as a code owner October 10, 2024 16:52
tonyfromundefined
tonyfromundefined approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@tonyfromundefined tonyfromundefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전반적으로 내용이 깔끔하니 좋네요 ㅎㅎ

피드백

  • 실제 CLI 에 쳤을때 나오는 메시지나, 생성된 파일 등을 스크린샷으로 포함하면 더 생생하게 느낄 수 있을거같아요.
  • 전반적으로 조금 어투가 딱딱하다고 느껴지는거같아요. (AI 쓴 것 같은 느낌이 들어요) 좀 더 부드럽게 바꿔보면 어떨까 생각이 들었어요.

@day1companyhaewooklee day1companyhaewooklee merged commit 1e2e6ce into main Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyfromundefined tonyfromundefined tonyfromundefined approved these changes

@chan99k chan99k Awaiting requested review from chan99k

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yejin0O0 @tonyfromundefined @day1companyhaewooklee