페이지 기능: 채널 페이지 유튜브 api 연결 #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
3 tasks
bottlewook
requested changes
Feb 28, 2024
src/app/channel/page.tsx
Outdated
| title: 'Teddy Swims - You\'re Still The One (Shania Twain Cover)', | ||
| description: 'Teddy Swims - You\'re Still The One (Shania Twain Cover)', | ||
| }]; | ||
| const channelList = { |
There was a problem hiding this comment.
Suggested change
| const channelList = { | |
| const CHANNEL_LIST = { |
src/app/channel/page.tsx
Outdated
| <div> | ||
| <Header className={cx('header')} /> | ||
| <> | ||
| <div className={cx('headerTitleContainer')}> |
There was a problem hiding this comment.
하나 감쌀 땐 wrapper로 하시는 게 좋을 것 같아요!
| return ( | ||
| <ChannelArticle key={data.id} data={data} /> | ||
| <ChannelArticle key={idx} data={data} /> |
There was a problem hiding this comment.
cud 기능이 없어서 idx 사용해도 좋을 것 같아요~
| const cx = classNames.bind(styles); | ||
|
|
||
| function ChannelArticle({ data }: ChannelArticleProps) { | ||
| const opts = { |
There was a problem hiding this comment.
컴포넌트 랜더링 될 때마다 객체가 재생성 되므로 useMemo를 사용해도 좋지만 이 경우는 값이 바뀌지 않기 때문에 컴포넌트 상위로 빼주시고 변수명은 UPPER_CASE로 바꿔주세요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
해당 사항 (중복 선택)
설명
Key Changes
How it Works
To Reviewers