페이지 UI: 검색 페이지 #104
Merged
페이지 UI: 검색 페이지 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bottlewook
requested changes
Jan 21, 2024
src/app/search/page.tsx
Outdated
|
|
||
| import classNames from 'classnames/bind'; | ||
|
|
||
| import ProductArticle from '@/components/shared/product-article/ProductArticle'; |
There was a problem hiding this comment.
Suggested change
| import ProductArticle from '@/components/shared/product-article/ProductArticle'; | |
| import ProductArticle from '@shared/product-article/ProductArticle'; |
| setSelectedLabel={setSelectedLabel} | ||
| /> | ||
| </div> | ||
| <div className={cx('productArticleContainer')}> |
There was a problem hiding this comment.
ProductArticle 컴포넌트에 box-shadow 스타일 추가해주세요!
src/app/search/page.tsx
Outdated
| const dropdownRef = useRef<HTMLInputElement>(null); | ||
|
|
||
| const [selectedLabel, setSelectedLabel] = useState(options[0].label); | ||
| const [isFilterDrawerOpen, setIsFilterDrawerOpen] = useState(false); |
There was a problem hiding this comment.
Suggested change
| const [isFilterDrawerOpen, setIsFilterDrawerOpen] = useState(false); | |
| const [isOpenFilterDrawer, setIsOpenFilterDrawer] = useState(false); |
동사가 먼저 오는 게 좋아보여요!
src/app/search/page.tsx
Outdated
| <main className={cx('mainContainer')}> | ||
| <SearchBar /> | ||
| <div className={cx('filterWrapper')}> | ||
| <span>{`총 ${productArticleData.length}개`}</span> |
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
해당 사항 (중복 선택)
설명
Key Changes
How it Works
To Reviewers
검색페이지 제작 도중에 dropdown 컴포넌트를 수정하였습니다. (클릭된 라벨이 선택되도록)
검색페이지에 사용되는 dropdown option 중에 위반제품순이 있는데 글자수가 길어서 레이아웃이 깨지고 있습니다. 이부분을 글자 크기대로 늘릴지 아니면 글자가 잘리도록 할지 고민됩니다! 🤔
이후에 filter drawer ui 제작 예정입니다.