Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] 지하철 시간표 관련 코드 구현 #88
[FEAT] 지하철 시간표 관련 코드 구현 #88
Changes from 18 commits
2d6c324
8423257
127e64c
7c03c4a
67a0bd3
0f94345
f8988b7
ca90c0c
96dff41
6c41dab
a61a41c
65a8c5d
94ff006
a77bcd8
7ecf3ed
37ce3dd
be81cda
f8a44c2
49023c8
4c97313
0805f20
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is... method 의 경우 boolean 반환을 하는 것이 적합합니다. 그렇게 될 경우 throw의 책임은 상위 메소드인 getTimeTableList() 에서 가지게됩니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
만약 throw를 해당 부분에서 원한다면 check... 와 같은 부분으로 변경하는 것이 조금 더 적합해보이고, 더 나아가서는 해당 Validator를 별도로 생성하는 것이 좋지 않을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: private method 의 경우 테스트가 불가하기 때문... 만약에 여기서만 사용한다면, existsById 를 그냥 호출하고 체크하는 것이 더 나을 것 같음.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저도 작성하면서 뭔가 걸리는게 있었는데 이거였군요...
isExisted 메서드 제거하고 existsById를 바로 호출하는 것으로 변경했습니다!