Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] 공공 api키 관리 기능 구현 #148

Merged
merged 13 commits into from
Aug 29, 2024
Merged

[FEAT] 공공 api키 관리 기능 구현 #148

merged 13 commits into from
Aug 29, 2024

Conversation

Gyaak
Copy link
Collaborator

@Gyaak Gyaak commented Aug 29, 2024

Api Key 관련 클래스 이름 리팩토링

  • ApiKeyProperty -> ApiKeyProvider
  • BusApiKeyProperty -> PropertyApiKeyProvider

Persistence Api Key 구현

  • 관리자 페이지에서 api키 관리 (등록/수정)
  • 등록된 api키는 db에 저장되고 매일자정 사용량이 초기화됨
  • 사용량을 초과한 api key는 PersistenceApiKeyProvider에서 제거되고 자정이 다시 추가됨
  • 사용량은 메모리에 저장하고 20분마다 db에 업데이트

close #146

@Gyaak Gyaak added ⌨️ BE Backend 작업 ✨ feat 기능 개발과 관련된 라벨입니다. labels Aug 29, 2024
@Gyaak Gyaak self-assigned this Aug 29, 2024
JuneParkCode
JuneParkCode reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@JuneParkCode JuneParkCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API Key 의 경우 각 API Service 마다 할당되어 해당 부분을 고려해야함.

JuneParkCode
JuneParkCode approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@JuneParkCode JuneParkCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API 경로마다 Key 관리가 되어 간단해졌네요.굿

@Gyaak Gyaak merged commit 4e78488 into develop Aug 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuneParkCode JuneParkCode JuneParkCode approved these changes

@ss0ngcode ss0ngcode Awaiting requested review from ss0ngcode

Assignees

@Gyaak Gyaak

Labels
⌨️ BE Backend 작업 ✨ feat 기능 개발과 관련된 라벨입니다.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] (Admin) 공공 api key관리
2 participants
@Gyaak @JuneParkCode