-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] 개발용 / 배포용 개발 환경 분리 #144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- server를 컨테이너로 올리기 위해 docker compose에 작성 - nginx 및 ssl인증(certbot)을 위해 docker compose에 작성 - ssl 인증을 위한 init-letsencrypt.sh 작성 - Github Action을 통해 CI / CD를 위한 gradle-build.yml 작성
- PR시 실행 제외 - EC2 보안그룹 인바운드 규칙 임시 추가 및 삭제 설정 - 기존 docker image 삭제 수정
- application.yaml에서 local / prod로 구분지어서 사용 가능 - SecurityConfig에서 개발 환경에 맞게 url 변경
JuneParkCode
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- application.yaml ddl-auto update로 변경 - docker-compose.yaml ${SPRING_DATASOURCE_URL} => ${MYSQL_URL}로 변경 - 배포 시 docker-compose.yaml EC2에 복사
Gyaak
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업내용
@Value
를 통해 application.yaml 환경변수 사용추가 작업내용
Closes #123