refactor: DTO 의 NoArgsConstructor 수정

Kernel360 · Aug 3, 2024 · 386201d · 386201d
1 parent be9bd18
commit 386201d
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 22 deletions.
diff --git a/server/src/main/java/com/talkka/server/user/dao/UserEntity.java b/server/src/main/java/com/talkka/server/user/dao/UserEntity.java
@@ -20,6 +20,7 @@
 import jakarta.persistence.GenerationType;
 import jakarta.persistence.Id;
 import jakarta.persistence.OneToMany;
+import lombok.AccessLevel;
 import lombok.AllArgsConstructor;
 import lombok.Builder;
 import lombok.Getter;
@@ -30,7 +31,7 @@
 @Entity(name = "users")
 @Getter
 @Builder
-@NoArgsConstructor
+@NoArgsConstructor(access = AccessLevel.PROTECTED)
 @AllArgsConstructor
 @ToString
 @EntityListeners(AuditingEntityListener.class)

diff --git a/server/src/main/java/com/talkka/server/user/dto/UserCreateDto.java b/server/src/main/java/com/talkka/server/user/dto/UserCreateDto.java
@@ -6,13 +6,11 @@
 import lombok.AllArgsConstructor;
 import lombok.Builder;
 import lombok.Getter;
-import lombok.NoArgsConstructor;
 import lombok.ToString;
 
 @Getter
 @Builder
 @ToString
-@NoArgsConstructor
 @AllArgsConstructor
 public class UserCreateDto {
 	private String name;

diff --git a/server/src/main/java/com/talkka/server/user/dto/UserCreateReqDto.java b/server/src/main/java/com/talkka/server/user/dto/UserCreateReqDto.java
@@ -1,5 +1,6 @@
 package com.talkka.server.user.dto;
 
+import lombok.AccessLevel;
 import lombok.AllArgsConstructor;
 import lombok.Builder;
 import lombok.Getter;
@@ -9,7 +10,7 @@
 @Getter
 @Builder
 @ToString
-@NoArgsConstructor
+@NoArgsConstructor(access = AccessLevel.PROTECTED)
 @AllArgsConstructor
 public class UserCreateReqDto {
 	private String nickname;

diff --git a/server/src/main/java/com/talkka/server/user/dto/UserDto.java b/server/src/main/java/com/talkka/server/user/dto/UserDto.java
@@ -9,13 +9,11 @@
 import lombok.AllArgsConstructor;
 import lombok.Builder;
 import lombok.Getter;
-import lombok.NoArgsConstructor;
 import lombok.ToString;
 
 @Getter
 @Builder
 @ToString
-@NoArgsConstructor
 @AllArgsConstructor
 public class UserDto {
 	private Long userId;

diff --git a/server/src/main/java/com/talkka/server/user/dto/UserRespDto.java b/server/src/main/java/com/talkka/server/user/dto/UserRespDto.java
@@ -1,16 +1,13 @@
 package com.talkka.server.user.dto;
 
-import lombok.AccessLevel;
 import lombok.AllArgsConstructor;
 import lombok.Builder;
 import lombok.Getter;
-import lombok.NoArgsConstructor;
 import lombok.ToString;
 
 @Getter
 @Builder
 @ToString
-@NoArgsConstructor(access = AccessLevel.PRIVATE)
 @AllArgsConstructor
 public class UserRespDto {
 	private Long userId;

diff --git a/server/src/main/java/com/talkka/server/user/dto/UserUpdateReqDto.java b/server/src/main/java/com/talkka/server/user/dto/UserUpdateReqDto.java
@@ -1,5 +1,6 @@
 package com.talkka.server.user.dto;
 
+import lombok.AccessLevel;
 import lombok.AllArgsConstructor;
 import lombok.Builder;
 import lombok.Getter;
@@ -9,7 +10,7 @@
 @Getter
 @Builder
 @ToString
-@NoArgsConstructor
+@NoArgsConstructor(access = AccessLevel.PROTECTED)
 @AllArgsConstructor
 public class UserUpdateReqDto {
 	private String nickname;

diff --git a/server/src/main/java/com/talkka/server/user/service/UserService.java b/server/src/main/java/com/talkka/server/user/service/UserService.java
@@ -37,22 +37,13 @@ public UserDto createUser(UserCreateDto userCreateDto) {
 	public UserDto updateUser(Long userId, UserUpdateReqDto reqDto) {
 		UserEntity user = userRepository.findById(userId)
 			.orElseThrow(() -> new BadRequestException("존재하지 않는 유저입니다."));
-		// 중복 닉네임 체크
+
 		if (!reqDto.getNickname().equals(user.getNickname())
 			&& this.isDuplicatedNickname(reqDto.getNickname())) {
 			throw new BadRequestException("중복된 닉네임 입니다.");
 		}
-		UserEntity updatedUser = UserEntity.builder() // refactoring 필요함.
-			.userId(userId)
-			.nickname(reqDto.getNickname())
-			.oauthProvider(user.getOauthProvider())
-			.accessToken(user.getAccessToken())
-			.grade(user.getGrade())
-			.createdAt(user.getCreatedAt())
-			.updatedAt(user.getUpdatedAt())
-			.busReviews(user.getBusReviews())
-			.build();
-		UserEntity savedUser = userRepository.save(updatedUser);
+		user.setNickname(reqDto.getNickname());
+		UserEntity savedUser = userRepository.save(user);
 
 		return UserDto.of(savedUser);
 	}