Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing percentPlayed field to onPlayBackEnded events #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HumorBaby
Copy link

The onPlayBackEnded needed to specify that percentPlayed was a valid
substitution field.

The event allows for (and even provides in the example) a field for percentPlayed:

'varArgs': {'%mt': 'mediaType', '%fn': 'fileName', '%ti': 'title', '%ar': 'aspectRatio', '%ht': 'height',
'%wi': 'width', '%sm': 'stereomode', '%se': 'season', '%ep': 'episode', '%st': 'showtitle',
'%at': 'artist', '%al': 'album'},
'expArgs': {'mediaType': 'movie', 'fileName': 'G:\\movies\\Star Wars - Episode IV\\movie.mkv',
'title': 'Star Wars Episode IV - A New Hope', 'percentPlayed': '26'}

yet, this field is never substituted in args.

I used %pp as the two-letter field name despite there already being another %pp for profilePath. These two fields should never collide, so I figured it was okay to do this.

The `onPlayBackEnded` needed to specify that `percentPlayed` was a valid
substitution field.
@HumorBaby HumorBaby changed the title Adds missing percentPlayed field to onPlayBackEnded events Add missing percentPlayed field to onPlayBackEnded events Mar 11, 2019
@i3laze
Copy link

i3laze commented Mar 13, 2019

Will this fix the fact add-on isn’t working in Leia at all? :(

pikim added a commit to pikim/script.service.kodi.callbacks that referenced this pull request Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants