Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Used blocking operation blPop for locking #45

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stekycz
Copy link
Contributor

@stekycz stekycz commented Mar 26, 2015

Proof of concept

Brings better performance without no need of using active waiting for the lock.

Please, validate it again and again. I have spent a few hours validating it so I can miss something important.

@stekycz stekycz force-pushed the feature/blocking-lock branch from 80f9efd to f105e52 Compare March 26, 2015 10:19
@JakubKontra
Copy link

Huh, I thinks its good idea! It seems to be very good! Good Job Martin!

@fprochazka
Copy link
Member

Great work!

blowing mind

@stekycz
Copy link
Contributor Author

stekycz commented Mar 27, 2015

Questions

  • Should I use constants for :control and :timeout string?
  • Is it ok to have so many keys matching in test? I guess it is because of expiration however I would like to know your opinion.

@stekycz
Copy link
Contributor Author

stekycz commented Mar 27, 2015

  • :timeout does not have to be timestamp, it should be random inserting instead
  • rename :control to more appropriate name (perhaps :exist or :in-use) - maybe use value 1?

@fprochazka
Copy link
Member

@stekycz I have no idea, I won't have time to think about it sooner than this sunday.

@stekycz
Copy link
Contributor Author

stekycz commented Mar 27, 2015

@fprochazka Take a time. I also want to think about it again :-)

@matej21
Copy link
Contributor

matej21 commented Mar 28, 2015

  • session write should fail if lock expires

@fprochazka fprochazka changed the title Used blocking operation blPop for locking [WIP] Used blocking operation blPop for locking Nov 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants