Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pandas warning #74

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Conversation

sapountzis
Copy link
Contributor

Currently the groupby raises a warning by pandas as the default behavior will change

From pandas documentation:

observed : bool, default False
This only applies if any of the groupers are Categoricals. If True: only show observed values for categorical groupers. If False: show all values for categorical groupers.

Deprecated since version 2.1.0: The default value will change to True in a future version of pandas.

To retain the old behavior we need to set observed=False which also fixes the warning

@mbaak
Copy link
Contributor

mbaak commented Dec 22, 2023

Thank you! Will have a quick test run and merge :)

@sapountzis
Copy link
Contributor Author

Thanks! Any plans for a new release in pip?

@mbaak
Copy link
Contributor

mbaak commented Dec 28, 2023

We're working on it :)

@mbaak mbaak closed this Dec 29, 2023
@mbaak mbaak reopened this Dec 29, 2023
@mbaak mbaak merged commit 0dd3553 into KaveIO:master Dec 29, 2023
42 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants