Fixes an initialization race condition #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If an interrupt occurs during the fpga_probe routine, the driver can crash due to an uninitalized PCI drvdata field. This change moves the allocation of the PCI drvdata to the prologue of the fpga_probe() routine and then relies upon drvdata->id to determine initialization readiness during the intrpt_handelr() routine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can crash due to an uninitalized PCI drvdata field in intrpt_handler()
This change moves the allocation of the PCI drvdata to the prologue
of the fpga_probe() routine and then relies upon drvdata->id to determine
initialization readiness during the intrpt_handler() routine.