Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info on return port. #32

Closed
wants to merge 1 commit into from
Closed

Conversation

adyanth
Copy link

@adyanth adyanth commented Oct 21, 2023

Fixes #31

With #pragma HLS INTERFACE mode=s_axilite port=return,
image

We no longer see the ap_ctrl unconnected.
image

@adyanth
Copy link
Author

adyanth commented Oct 22, 2023

Cc: @rck289 @zhenghuama

@zhenghuama
Copy link
Collaborator

Hi Adyanth, thanks for the pull request. I double checked your request and in fact, you can set the return port in GUI. The screen shot at the end of 1.3 also showed what the directive tab should look like after we configure everything correctly (with commands for all 3 ports).
However, I apologize that my wordings in the original guide may be unclear and many ppl don't know they must also configure the return port by right-click the module itself (screenshot is too small, easy to be ignored). Also, thank you for providing an alternative (and better) way of configuring via pragma commands.
So, instead of simply merging the request, I updated that section with more detailed explanations.
Thank you!

@zhenghuama zhenghuama closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pynq Memory Mapped IO Lab issue with ap_ctrl not on AXI
2 participants