TECH: added bluetooth's switcher #684
Conversation
ersanin
requested review from
matzuk,
AzamatCherchesov,
eakurnikov,
RuslanMingaliev,
Nikitae57 and
CherchesovAzamat
as code owners
ersanin
force-pushed
the
TECH-device-bluetooth-switch
branch
from
1a7310f
to
32eb9e1
Compare
| logger.i("Bluetooth is not supported") | ||
| return | ||
| } | ||
| logger.i("${if (enable) "En" else "Dis"}able bluetooth") |
There was a problem hiding this comment.
Please, make two separate calls to the logger. Concatenating log strings make them almost imposible to find in the code
| throw AdbServerException("Failed to change Bluetooth state using ABD") | ||
| } | ||
| } catch (e: AdbServerException) { | ||
| false |
There was a problem hiding this comment.
Catching AdbServerException here may lead to the missing the fact that adb server is down or broken. Please, check that the test crashes when the adb server is disabled. I would throw an exception in the toggleBluetooth method if bluetooth state didn't change since we failed to set the test to the desired state
There was a problem hiding this comment.
Why should the test fail if the adb server is disabled? In this case we can still try to switch bluetooth via quick access settings.
| val height = targetContext.resources.displayMetrics.heightPixels | ||
| val width = targetContext.resources.displayMetrics.widthPixels | ||
|
|
||
| UiSystem { |
There was a problem hiding this comment.
Plesae, leave a comment on what's going on here
No description provided.