Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-405: init commit with simple code gen #584

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

ISSUE-405: init commit with simple code gen #584

wants to merge 26 commits into from

Conversation

AzamatCherchesov
Copy link
Collaborator

No description provided.

@CLAassistant
Copy link

CLAassistant commented Sep 28, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Nikitae57
Nikitae57 requested changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@Nikitae57 Nikitae57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please:

  1. Create a new module, move the code there
  2. Split this file into multiple classes
  3. Write a couple of unit tests
  4. Would be great to generate a jar so users wouldn't need to compile this class

page-object-code-gen/createPageObjectFromUiDump.kt Outdated Show resolved Hide resolved
page-object-code-gen/createPageObjectFromUiDump.kt Outdated Show resolved Hide resolved
page-object-code-gen/createPageObjectFromUiDump.kt Outdated Show resolved Hide resolved
page-object-code-gen/createPageObjectFromUiDump.kt Outdated Show resolved Hide resolved
page-object-code-gen/createPageObjectFromUiDump.kt Outdated Show resolved Hide resolved
page-object-code-gen/createPageObjectFromUiDump.kt Outdated Show resolved Hide resolved
page-object-code-gen/createPageObjectFromUiDump.kt Outdated Show resolved Hide resolved
page-object-code-gen/createPageObjectFromUiDump.kt Outdated Show resolved Hide resolved
page-object-code-gen/createPageObjectFromUiDump.kt Outdated Show resolved Hide resolved
page-object-code-gen/createPageObjectFromUiDump.kt Outdated Show resolved Hide resolved
@OvsyannikovMaksim OvsyannikovMaksim marked this pull request as ready for review January 19, 2024 12:11
@Nikitae57 Nikitae57 self-requested a review January 24, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OvsyannikovMaksim OvsyannikovMaksim OvsyannikovMaksim left review comments

@CherchesovAzamat CherchesovAzamat CherchesovAzamat approved these changes

@matzuk matzuk Awaiting requested review from matzuk matzuk is a code owner

@eakurnikov eakurnikov Awaiting requested review from eakurnikov eakurnikov is a code owner

@RuslanMingaliev RuslanMingaliev Awaiting requested review from RuslanMingaliev RuslanMingaliev is a code owner

@Nikitae57 Nikitae57 Awaiting requested review from Nikitae57 Nikitae57 is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AzamatCherchesov @CLAassistant @Nikitae57 @OvsyannikovMaksim @CherchesovAzamat