Only show last 6 version updates on admin settings screen #3368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple split to only show the last 6 update log results. This stops the page from trying to load 20+ versions going back well over 2 years. Honestly even 6 feels like a lot. We could lower it if we wanted.
|
I'd like this implementation to change. Have the API take a int (6) so that the UI can request only the lastest releases. Then refactor all the way down to the VersionService code. This way we don't do extra work for that one flow, but we can keep it existing for others. Use a default value of 0 to ignore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
settings#admin-systemscreen. This stops the page from trying to load 20+ versions going back well over 2 years.Honestly even 6 feels like a lot. We could lower it since going back that far brings us to pretty old versions that aren't relevant anymore.