Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX Overhaul Part 1 #3047

Merged
merged 147 commits into from
Aug 9, 2024
Merged

UX Overhaul Part 1 #3047

merged 147 commits into from
Aug 9, 2024

Conversation

therobbiedavis
Copy link
Collaborator

@therobbiedavis therobbiedavis commented Jul 8, 2024

image

background animation - phase 4 - completion

image

image

This is the first pass and initial PR to bring the new UX to Kavita. Note that Series detail and all screens around that (outside of the colorscape functionality) will follow in a separate PR due to the size of the changes. Nightly testers please leave copious amounts of feedback. Our ears are open.

Added

  • Added: Replaced default Dark theme which will begin our UX overhaul. The previous dark theme is still available on the theme repo.
  • Added: Added a lot of ability to theme the login screen, including the background image.
  • Added: Added ColorScapes. ColorScapes is a new dynamic tinting system for Kavita. During cover generation, Kavita will pick primary colors from the image and apply them to the background on pages where the image is a primary element (series detail for now). These are configurable via the theming system. (Light themes do not look good with this system, it should be disabled)
  • Added: Added a new actionable for Library to generate colorscapes (which is a soft refresh covers)

Changed

  • Changed: Changed the Login look and feel.
  • Changed: Changed the max password character length to 256.
  • Changed: Changed some headers, spacing, and positioning to make things more uniform across the app.
  • Changed: Revamped how settings/preferences work in the app. Following Plex' style, they are all on one page (RBS applies) with a dedicated left nav menu that groups based on functionality. (Sorry localizers, lots of string updates)
  • Changed: When navigating away from library/collection/bookmark/etc-detail, instead of just restoring position when interacting with a jumpkey, Kavita will now restore position down to the location of jump point in all cases.
  • Changed: Jump keys now show an animation instead of a tooltip to show number of series
  • Changed: Filter icon now shows an animation when actively configuring it
  • Changed: Moved some screens around to dedicated sections and most of Kavita+ screens are now on a new Scrobbling page (this is temp and will be updated with Kavita+ UX Refactor #2979)
  • Changed: Moved the customize modal into a dedicated settings item to make discovery of the feature easier.
  • Changed: Lots of small consistency issues and QoL tweaks on different pages to bring a better UX and interaction. A lot of functionality has been moved to drive a consistent experience and discovery of features.

Fixed

  • Fixed: Fixed an issue where autofilled passwords were getting truncated due to the max character length.
  • Fixed: Fixed a side-nav css var that was inappropriately assigned. (Fixes [E-Ink] Menu icons invisible when sidebar closed #3043)
  • Fixed: Fixed a bug in theme manager where the active pill wouldn't have the correct color for non-dark themes
  • Fixed: Fixed a bug where reading list cards wouldn't promote/unpromote from actionables
  • Fixed: Fixed a bug where OPDS reading list feeds were missing pagination
  • Fixed: Fixed an edge case where busting Kavita+ cache in edit series then hitting close wasn't refreshing screen.

Theme

  • There were a ton of changes and new css variables. Wiki will be updated and extra documentation around colorscape system.
  • Tables are now themeable

Closes #3052

@therobbiedavis therobbiedavis changed the title Feature/revamped ux Revamped Login & New default theme Jul 8, 2024
@therobbiedavis
Copy link
Collaborator Author

@majora2007 I think there may need a migration in order to either update or remove the previous dark theme from the user's databases since I moved that over to the theme repo.

Copy link
Member

@majora2007 majora2007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments overall. As requested in discord, let's revert the changes to the system them and move the current Dark theme to Theme repo as Dark-Legacy given this is the start of the new UX.

- Updated nav-offset to css var
- Change ID selector to class selector
- Fixed more uniformity
- Added better naming to the layers and documentation
- Fixd the splashpage to use the navbar-offset css var
@majora2007 majora2007 changed the title Revamped Login & New default theme Revamped Login & New UX Start Jul 11, 2024
@majora2007
Copy link
Member

The backend will only allow 32 characters, as you can see in the Dtos.

Do you mean to update this as well?
[StringLength(32, MinimumLength = 6)]
public string Password { get; set; } = default!;

@majora2007
Copy link
Member

As discussed in person, there are a few issues around broken styles on modals and whatnot. I will in addition be implementing the accent functionality in this PR so first release is useable.

We can consider this PR on hold until we get through these things (with holiday upcoming, expect 1 month).

@majora2007 majora2007 marked this pull request as draft July 12, 2024 12:04
majora2007 and others added 26 commits August 9, 2024 06:42
Updated the code so that isAdmin$ check is driven from accountService and I'm not repeating logic everywhere.
@majora2007 majora2007 marked this pull request as ready for review August 9, 2024 17:43
@majora2007 majora2007 merged commit ff79710 into develop Aug 9, 2024
7 checks passed
@majora2007 majora2007 deleted the feature/revamped-ux branch August 9, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
db-migration This story needs a DB Migration
Projects
Development

Successfully merging this pull request may close these issues.

UX Foundation [E-Ink] Menu icons invisible when sidebar closed
2 participants