Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email is now Built-in! #2635

Merged
merged 12 commits into from
Jan 20, 2024
Merged

Email is now Built-in! #2635

merged 12 commits into from
Jan 20, 2024

Conversation

majora2007
Copy link
Member

Added

  • Added: New setting in Email settings to let you use Customized Template files. If this is true, Kavita will pick templates from config/templates rather than internal storage. Fallback is available. You then own the onset to stay up to date with email template changes.

Changed

  • Changed: Email is now baked into Kavita. If email is not setup then all flows will now just work. The extra security measures will only work with email being setup (and HostName set). Kavita will no longer try to identify if the server is accessible externally. You will have to set HostName and setup the emailer going forward. (Closes Move KavitaEmail into Kavita #2626 )

Fixed

  • Fixed: Fixed and polished a lot of the email flows.

@majora2007
Started the migration of Kavita Email into Kavita.
85af3a8
@majora2007
Hooked up the UI without validation for the email settings.
0ca2720
@majora2007
Added a new build target for M1 chips.
5039540 
Added a manual migration to download templates.

Implemented one flow for test email settings.
@majora2007
Send Test Email flow is working
4dba3e5
@majora2007
Migrated Invite User Email
9a16946
@majora2007
Change email now properly refreshes when email isn't setup.
a3940a7
@majora2007
2 flows left.
5c8bf93 
Refactored the code so that users can have customized templates, but we will ship with them by default. They have to opt-into customization and take ownership of changes.
@majora2007
Fixed up the resend email invite to use the invite email template and…
d70bf64 
… also properly update confirmation token for the user.
@majora2007
All the email flows are now migrated and are streamlined to work much…
ec5c1fc 
… better.
@majora2007
Removed a template that's not needed anymore.
099964e
@majora2007
Small change to the wording for email change.
7598685
@majora2007
Fixed templates not packing
81ef903
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 20, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 20, 2024
View reviewed changes
API/Controllers/AccountController.cs Dismissed Show dismissed Hide dismissed
API/Data/ManualMigrations/MigrateEmailTemplates.cs Dismissed Show dismissed Hide dismissed
API/Controllers/AccountController.cs Dismissed Show dismissed Hide dismissed
API/Data/ManualMigrations/MigrateEmailTemplates.cs Dismissed Show dismissed Hide dismissed
API/Data/ManualMigrations/MigrateEmailTemplates.cs Dismissed Show dismissed Hide dismissed
API/Data/ManualMigrations/MigrateEmailTemplates.cs Dismissed Show dismissed Hide dismissed
API/Controllers/AccountController.cs Dismissed Show dismissed Hide dismissed
@majora2007 majora2007 merged commit a85644f into develop Jan 20, 2024
7 checks passed
@majora2007 majora2007 deleted the feature/email branch January 20, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move KavitaEmail into Kavita
1 participant
@majora2007