New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small Bugfixes #2414

Merged

majora2007 merged 8 commits into develop from bugfix/cover-chooser-refactor

Nov 8, 2023

Member

majora2007 commented Nov 8, 2023

Changed

Changed: Cover chooser no longer has an apply button. Upon adding or selecting a cover, it will instantly take effect. (Fixes Volume/Chapter Covers aren't working when using a URL #2379)
Changed: Series detail metadata (summary and tags) will now be expanded to a limit by default on desktop
Changed: New implementation for downloading files to be a lot simpler and should work better on iOS

Fixed

Fixed: Fixed a bug where publication status was getting set to Ended when it shouldn't. Ended should only be set when there is at least a Count within any chapter.
Fixed: Removed debug code from webtoon scroller (develop)

majora2007 added 8 commits

November 7, 2023 18:46


          Fixed up cover chooser. There is no more apply button. Upon adding a …

c0cc7a0

…file/url or selecting, the save will take place immediately.


          Trialing out showing all of series detail metadata section on desktop…

7b3bec1

… by default.


          Another fix around publication status. Ended shouldn't be set unless …

23a079c

…there is at least one Count set in the series.


          Removed debug code on infinite scroller

ed4bb9c


          Removed file-saver for a homegrown solution that doesn't have potenti…

c05b0f3

…al fallout.


          Updated a test to better reflect the title

3fad585


          Fully removed file-saver and eventsource, which doesn't seem needed.

132e37b


          Removed angular-animations, not using it

84b3f29

sonarcloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

majora2007 merged commit b7e7eaf into develop

7 checks passed

majora2007 deleted the bugfix/cover-chooser-refactor branch

November 8, 2023 18:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet