Fix: Exclude not working with absolute path in some cases (#593)

selene/Cargo.toml

@@ -35,6 +35,7 @@ tracy-client = { version = "0.14.1", optional = true }
 threadpool = "1.8"
 toml.workspace = true
 ureq = { version = "2.6.2", features = ["json"], optional = true }
+pathdiff = "0.2.2"
 
 [dev-dependencies]
 pretty_assertions = "1.3"

selene/src/main.rs

@@ -512,6 +512,7 @@ fn start(mut options: opts::Options) {
 
     let (config, config_directory): (CheckerConfig<toml::value::Value>, Option<PathBuf>) =
         match options.config {
+            // User provides a config file. We must read it and report if it is misconfigured.
             Some(config_file) => {
                 let config_contents = match fs::read_to_string(&config_file) {
                     Ok(contents) => contents,
@@ -522,10 +523,16 @@ fn start(mut options: opts::Options) {
                 };
 
                 match toml::from_str(&config_contents) {
-                    Ok(config) => (
-                        config,
-                        Path::new(&config_file).parent().map(Path::to_path_buf),
-                    ),
+                    Ok(config) => {
+                        // Get config directory to using absolute path.
+                        // There is case where `config = Some("selene.toml")`,
+                        // which returns `""`` when getting parent directory.
+                        let config_directory = Path::new(&config_file)
+                            .canonicalize()
+                            .ok()
+                            .and_then(|path| path.parent().map(|path| path.to_path_buf()));
+                        (config, config_directory)
+                    }
                     Err(error) => {
                         error!("Config file not in correct format: {}", error);
                         std::process::exit(1);
@@ -636,6 +643,26 @@ fn start(mut options: opts::Options) {
 
     let pool = ThreadPool::new(options.num_threads);
 
+    // Directory for matching files pattern.
+    // If user provides a config file, we use that as our working directory, otherwise fallback to the current directory.
+    // The working directory needs to be an absolute path to match with paths in different directories.
+    let working_directory = config_directory.or_else(|| current_dir.canonicalize().ok());
+
+    let is_excluded = |path: &Path| -> bool {
+        if options.no_exclude {
+            return false;
+        }
+
+        // File pattern between the path we are checking and current working directory.
+        let file_pattern = working_directory.as_ref().and_then(|dir| {
+            path.canonicalize()
+                .ok()
+                .and_then(|path| pathdiff::diff_paths(path, dir))
+        });
+
+        file_pattern.is_some_and(|pattern| exclude_set.is_match(&pattern))
+    };
+
     for filename in &options.files {
         if filename == "-" {
             let checker = Arc::clone(&checker);
@@ -649,7 +676,7 @@ fn start(mut options: opts::Options) {
                     let checker = Arc::clone(&checker);
                     let filename = filename.to_owned();
 
-                    if !options.no_exclude && exclude_set.is_match(&filename) {
+                    if is_excluded(Path::new(&filename)) {
                         continue;
                     }
 
@@ -671,7 +698,7 @@ fn start(mut options: opts::Options) {
                         for entry in glob {
                             match entry {
                                 Ok(path) => {
-                                    if !options.no_exclude && exclude_set.is_match(&path) {
+                                    if is_excluded(&path) {
                                         continue;
                                     }