Error mixed table #586
Merged
Error mixed table #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix type annotation in `getLatestSeleneRelease` function
Update mixed table lint error message to be more descriptive
Revert type annotation
Kampfkarren
reviewed
Feb 6, 2024
Co-authored-by: boyned//Kampfkarren <[email protected]>
|
Scrap that review, forgot to change the stderr file, will do that tomorrow. |
Error messages now match (should be good to merge now)
Fixed a Clippy error
|
@Kampfkarren All good to review now! |
chriscerie
reviewed
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #572
It makes the error message for mixed tables more descriptive and explains why they're bad and should be avoided.