-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove version constraints on container images #549
Remove version constraints on container images #549
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make use build-time variables instead? That would allow for more flexibility to build the Docker Image. See #550 for some ideas I had in mind.
Do we need this flexibility? I'm asking because I prefer to add the minimal needed abstraction only. In addition, I suggest to distinguish between fixing and enhancing the image. Other ideas for enhancements:
|
Don't fix what's not broken is definitely the easier way around the issue with the Docker build issue right now tbh. The flexible enhancements I suggested on the other hand is to future-proof a potential scenario wherein someone had to test the build against a different Rust Docker Image for whatever reason. For example, what if someone had to quickly check if a certain feature works on a particular Image or perhaps a specific version of Rust? Passing the build-time variables to The other intention I had in mind was, since the current |
@f1rstlady My assumption for the account is going to be |
This fixes errors during the build of this image, occuring due to non-existent version tags.
Head branch was pushed to by a user without write access
This fixes errors during the build of this image, occuring due to non-existent version tags.