Fix UDim2.new() linting (#570)

Kampfkarren · Nov 11, 2023 · a96aa40 · a96aa40
1 parent bf305f8
commit a96aa40
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased](https://github.com/Kampfkarren/selene/compare/0.26.0...HEAD)
+### Fixed
+- Fixed `UDim2.new()` firing the [`roblox_suspicious_udim2_new` lint](https://kampfkarren.github.io/selene/lints/roblox_suspicious_udim2_new.html).
 
 ## [0.26.0](https://github.com/Kampfkarren/selene/releases/tag/0.26.0) - 2023-11-11
 ### Added

diff --git a/selene-lib/src/lints/roblox_suspicious_udim2_new.rs b/selene-lib/src/lints/roblox_suspicious_udim2_new.rs
@@ -97,7 +97,7 @@ impl Visitor for UDim2CountVisitor {
             then {
                 let args_provided = arguments.len();
 
-                if args_provided >= 4 {
+                if args_provided == 0 || args_provided >= 4 {
                     return;
                 }
 

diff --git a/selene-lib/tests/lints/roblox_suspicious_udim2_new/roblox_suspicious_udim2_new.lua b/selene-lib/tests/lints/roblox_suspicious_udim2_new/roblox_suspicious_udim2_new.lua
@@ -13,3 +13,4 @@ UDim2.new(1, 1, 1, 1)
 UDim2.new(a, b, c, d)
 UDim2.fromOffset(1, 1)
 UDim2.fromScale(1, 1)
+UDim2.new()
-Original file line number
+Diff line change
@@ Expand Up / @@ -97,7 +97,7 @@ impl Visitor for UDim2CountVisitor { @@
                 then {
                     let args_provided = arguments.len();
-                    if args_provided >= 4 {
+                    if args_provided == 0 || args_provided >= 4 {
                         return;
                     }
@@ Expand Down @@