Run tests on CI + Fix regressions (#194)

* Run tests on CI

* Fix CI...passing

* Use new version of full-moon, bump version

* Use fields()

.github/workflows/build.yml

@@ -11,6 +11,8 @@ jobs:
     runs-on: windows-latest
     steps:
     - uses: actions/checkout@v1
+    - name: Run tests
+      run: cargo test
     - name: Build (All features)
       run: |
         cd selene
@@ -35,6 +37,8 @@ jobs:
     - uses: actions/checkout@v1
     - name: Install Rust
       run: curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
+    - name: Run tests
+      run: cargo test
     - name: Build (All features)
       run: |
         source $HOME/.cargo/env
@@ -59,6 +63,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v1
+    - name: Run tests
+      run: cargo test
     - name: Build (All features)
       run: |
         cd selene

CHANGELOG.md

@@ -1,6 +1,10 @@
 # Changelog
 This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.10.1] - 2020-12-22
+### Fixed
+- Fixed regressions related to numeric for loops.
+
 ## [0.10.0] - 2020-12-21
 ### Added
 - Added inline lint filtering, read [the documentation](https://kampfkarren.github.io/selene/usage/filtering.html) for more information.

selene-lib/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "selene-lib"
-version = "0.10.0"
+version = "0.10.1"
 license = "MPL-2.0"
 authors = ["Kampfkarren <[email protected]>"]
 description = "A library for linting Lua code. You probably want selene instead."
@@ -12,7 +12,7 @@ edition = "2018"
 [dependencies]
 codespan = "0.9"
 codespan-reporting = "0.9"
-full_moon = "0.8"
+full_moon = "0.9"
 id-arena = "2.2"
 if_chain = "1.0"
 lazy_static = "1.4"

selene-lib/src/ast_util/scopes.rs

@@ -231,7 +231,7 @@ impl ScopeVisitor {
     }
 
     fn read_table_constructor(&mut self, table: &ast::TableConstructor) {
-        for field in table.iter_fields() {
+        for field in table.fields() {
             match field {
                 ast::Field::ExpressionKey { key, value, .. } => {
                     self.read_expression(key);

selene-lib/src/ast_util/side_effects.rs

@@ -41,17 +41,18 @@ impl HasSideEffects for ast::Value<'_> {
             | ast::Value::Symbol(_) => false,
             ast::Value::FunctionCall(_) => true,
             ast::Value::ParseExpression(expression) => expression.has_side_effects(),
-            ast::Value::TableConstructor(table_constructor) => {
-                table_constructor.iter_fields().any(|field| match field {
+            ast::Value::TableConstructor(table_constructor) => table_constructor
+                .fields()
+                .into_iter()
+                .any(|field| match field {
                     ast::Field::ExpressionKey { key, value, .. } => {
                         key.has_side_effects() || value.has_side_effects()
                     }
 
                     ast::Field::NameKey { value, .. } => value.has_side_effects(),
 
                     ast::Field::NoKey(expression) => expression.has_side_effects(),
-                })
-            }
+                }),
             ast::Value::Var(var) => var.has_side_effects(),
         }
     }

selene-lib/src/rules/roblox_incorrect_roact_usage.rs

@@ -193,7 +193,7 @@ impl Visitor<'_> for IncorrectRoactUsageVisitor {
             }
         }
 
-        for field in arguments.iter_fields() {
+        for field in arguments.fields() {
             if let ast::Field::NameKey { key, .. } = field {
                 let property_name = key.token().to_string();
                 if !valid_properties.contains(property_name.as_str()) {

selene/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "selene"
-version = "0.10.0"
+version = "0.10.1"
 license = "MPL-2.0"
 authors = ["Kampfkarren <[email protected]>"]
 description = "A blazing-fast modern Lua linter written in Rust"
@@ -16,12 +16,12 @@ cfg-if = "0.1"
 chrono = "0.4"
 codespan = { version = "0.9", features = ["serialization"] }
 codespan-reporting = { version = "0.9", features = ["serialization"] }
-full_moon = "0.8"
+full_moon = "0.9"
 lazy_static = "1.4"
 glob = "0.3"
 num_cpus = "1.10"
 reqwest = { version = "0.9", optional = true }
-selene-lib = { path = "../selene-lib", version = "=0.10.0", default-features = false }
+selene-lib = { path = "../selene-lib", version = "=0.10.1", default-features = false }
 serde = { version = "1.0", features = ["derive"] }
 serde_json = "1.0"
 structopt = "0.3"