Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

Add tests to hooks #30

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

chriscerie
Copy link
Contributor

Adds tests to most hooks.

@Kampfkarren
Copy link
Owner

Will look into this more in depth later, but please expand every use of "deps" to "dependencies"--no shortened names here.

expect(test.useEffectRuns).to.equal(5)

test.setDependencies({ nil, nil })
task.wait(0.1)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need wait? CI shouldn't need yields.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should instead just call Roact.update directly

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants