Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump CosmosSDK to v0.50.11 and cleanup deps #213

Merged
merged 5 commits into from
Dec 20, 2024

Conversation

mbreithecker
Copy link
Member

@mbreithecker mbreithecker commented Dec 20, 2024

Summary by CodeRabbit

  • New Features
    • Introduced "Shared Staking" features, including consensus-validator stakes, pool-specific commission structures, and limits on voting power per pool.
  • Improvements
    • Updated dependencies to CosmosSDK v0.50.11 and other related libraries for enhanced stability and performance.
  • Bug Fixes
    • Removed governance-related functions to simplify the keeper interface, focusing on staker management and pool operations.

Copy link

coderabbitai bot commented Dec 20, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces significant changes to the project's staking mechanism and dependency management. The primary focus is on implementing Shared Staking features, which include consensus-validator stake usage, pool-specific commission structures, and voting power limits. Simultaneously, the project has updated its dependencies across multiple modules, upgrading Go versions, CosmosSDK, and various third-party libraries. The changes also involve removing certain governance-related functions from the stakers keeper, indicating a potential refactoring of the staking and governance interactions.

Changes

File Change Summary
CHANGELOG.md Added new features for Shared Staking and dependency updates
go.mod Updated Go version to 1.22.7, upgraded multiple dependencies including CosmosSDK to v0.50.11
interchaintest/go.mod Updated dependencies and Go version, including IBC-go and Cosmos SDK versions
x/stakers/keeper/exported_functions.go Removed governance-related methods: TotalBondedTokens, GetActiveValidators, GetDelegations

Sequence Diagram

sequenceDiagram
    participant Pool
    participant Validator
    participant StakingModule
    participant ConsensusLayer

    Pool->>StakingModule: Request Stake Allocation
    StakingModule->>ConsensusLayer: Validate Stake Limits
    ConsensusLayer-->>StakingModule: Confirm Allocation
    StakingModule->>Validator: Assign Commission
    Validator-->>Pool: Stake Confirmation
Loading

Poem

🐰 Hop, hop, through the staking lane,
Shared stakes now dance, no longer plain!
Validators twirl with new commission's grace,
Limits set, each pool finds its space.
Code evolves, a rabbit's delight! 🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d06e9a9 and 77590fa.

⛔ Files ignored due to path filters (1)
  • interchaintest/go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • interchaintest/go.mod (9 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 967b1d4 and d06e9a9.

⛔ Files ignored due to path filters (4)
  • go.sum is excluded by !**/*.sum
  • go.work is excluded by !**/*.work
  • go.work.sum is excluded by !**/*.sum
  • interchaintest/go.sum is excluded by !**/*.sum
📒 Files selected for processing (4)
  • CHANGELOG.md (1 hunks)
  • go.mod (12 hunks)
  • interchaintest/go.mod (8 hunks)
  • x/stakers/keeper/exported_functions.go (0 hunks)
💤 Files with no reviewable changes (1)
  • x/stakers/keeper/exported_functions.go
🔇 Additional comments (2)
CHANGELOG.md (1)

25-27: Verify the scope of changes in this PR

The PR title suggests this is a dependency update PR, but the changelog includes significant Shared Staking features marked as state machine breaking changes. Consider:

  1. Splitting these changes into separate PRs - one for dependencies and another for Shared Staking features
  2. Or updating the PR title and description to reflect the full scope of changes
go.mod (1)

24-24: LGTM: CosmosSDK version bump and dependency updates

The changes correctly implement the version bump to CosmosSDK v0.50.11 and include comprehensive dependency updates.

interchaintest/go.mod Outdated Show resolved Hide resolved
troykessler
troykessler previously approved these changes Dec 20, 2024
@mbreithecker mbreithecker merged commit fd798bd into main Dec 20, 2024
4 checks passed
@mbreithecker mbreithecker deleted the mbreithecker/update-dependencies branch December 20, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants