New User Interface #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asyms
approved these changes
May 15, 2024
asyms
added a commit
that referenced
this pull request
May 15, 2024
* Create AcceleratorValidator and Factory * Create WorkloadValidator and Factory * test works for tpu_like * tests work with new hardware definitions * Minor cleanup: examle file, nice print * restore get_total_inst_bandwidth function (used in stream) * Refactor AcceleratorFactory into CoreFactory, re-introduce in Core * make memory area a float * Multiplier area can be float * Extract LayetAttributes class from LayerNode for Stream compatibility * Make core allocation a list * Create ABC for LayerNode and DummyNode * Fix very nasty bug in LayerEquation * minor bug in spatial mapping generator * fix ruff error in AimcArray so CI/CD can run tetst * add cerberus library to requirements.txt * Fix bug in workload validator when using padding * fix minor bug in parsing * Fix __eq__ for LayerAttributes * Fix test energy/latency values after fixing bug in commit c408a13 * edit .pylintrc indentation from 2 to 4 Co-authored-by: RobinGeens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mappings, workloads and accelerators are now defined as yaml files. The files are validated in corresponding the
Validator, and converted into the internal representation inFactory.Notes:
IorW(and notXorYor ...). This just makes it easier for the validator. Do we need the freedom to rename Layer Operands or are there no use cases for this?Dependency: Pull request #49 (Reworked internals)