Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Incorrect Spatial Mapping Saving and Update If Condition in SpatialMappingGenerateStage #42

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Fix Incorrect Spatial Mapping Saving and Update If Condition in SpatialMappingGenerateStage #42

merged 3 commits into from
Feb 12, 2024

Conversation

JiacongSun
Copy link
Collaborator

Issue fixed on:

  • The user_spatial_mapping saved in the output JSON file will be incorrect when a layer dimension is mapped onto multiple hardware dimensions. This bug only affects the mapping in the output CME and has no impact on the cost estimation result.
  • Updated the if condition in the SpatialMappingGeneratorStage to identify cases when weight diagonal mapping is enabled and input served dimension is set.

@JiacongSun JiacongSun requested a review from asyms February 7, 2024 00:25
asyms
asyms approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@asyms asyms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asyms asyms merged commit 9032261 into KULeuven-MICAS:master Feb 12, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asyms asyms asyms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JiacongSun @asyms