-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add gemmx prameter support #327
Conversation
c4a3c21
to
087db85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK! Would it be more useful though that there is a default setting for the GeMM config?
Otherwise, people who want to use your gemm needs to always set the size?
hw/chisel_acc/src/main/scala/snax_acc/gemm_simd/BlockGemmRescaleSIMD.scala
Show resolved
Hide resolved
I don't know. Maybe it's better to ensure that people explicitly set the PE size? |
I'm not too picky so okay haha. Maybe we can add somekind of documentation on our documentation page for this 😄 |
We can! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, nice PR!
already a few high-level questions.
I'm not a big fan of our current build process because it routes everything to a single python command that can not be pipelined, and which parallel make does not like #228
For this specific PR though:
Just so you know, the transpose extension only works for 512 data width for readers.
Note: the pipelined SIMD only works for meshRow * meshCol = 64 cases so if you set pe array size that doesn't have 64 output, please take care to set with_pipeline = false.
Can you please please please verify this somewhere in software instead of just this comment
Who sets TRANSPOSE_EXTENSION_ENABLE
in the software makefile?
Is there an automatic way this is set?
I verified locally. Later relevant documentation will be added to push a warning on this.
The streamer header file gen will set it if a transpose extension is instantiated. |
In this PR, we add the parameter support for gemmx. More specifically, we: