Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add actual check on golden output #43

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Add actual check on golden output #43

merged 2 commits into from
Dec 11, 2023

Conversation

JosseVanDelm
Copy link
Contributor

To solve #42

@JosseVanDelm JosseVanDelm marked this pull request as ready for review December 11, 2023 16:50
jorendumoulin
jorendumoulin approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@jorendumoulin jorendumoulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k

@JosseVanDelm JosseVanDelm merged commit 6ce561a into main Dec 11, 2023
3 checks passed
@JosseVanDelm JosseVanDelm deleted the Josse/fix-check branch December 11, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorendumoulin jorendumoulin jorendumoulin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JosseVanDelm @jorendumoulin