transforms: (set_memory_layout) only apply on streaming_regions #334
+30
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosseVanDelm
approved these changes
Jan 9, 2025
| ) | ||
| if not isinstance(generic_op.body.block.first_op, QMacOp): | ||
| return | ||
| assert isinstance(generic_op := op.body.block.first_op, stream.GenericOp) |
There was a problem hiding this comment.
nit: Feels a bit weird to assign a variable inside an assertion?
Suggested change
| assert isinstance(generic_op := op.body.block.first_op, stream.GenericOp) | |
| generic_op = op.body.block.first_op | |
| assert isinstance(generic_op, stream.GenericOp) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to operate this pass only on schedules (after the autoflow scheduler), where the layout is determined automatically according to the access pattern to memory.
This is a first step, to make sure everything keeps working when setting the memory layout at this stage (instead of at linalg.generic level)