Fix gemmini kernel, add snakemake, remove Makefile #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+37
to
+40
| use rule preprocess_mlir from default_rules as default_preprocess_mlir | ||
|
|
||
|
|
||
| use rule translate_mlir from default_rules as default_translate_mlir |
There was a problem hiding this comment.
This is to indicate that we import them from the defaults.
use rule preprocess_mlir, translate_mlir from default_rules as default_*
Also works, but snakefmt wouldn't let me, maybe the newer versions fix this?
jorendumoulin
approved these changes
Dec 20, 2024
JosseVanDelm
force-pushed
the
Josse/add-gemmini-test
branch
from
a1cd693 to
e37806c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an error in changing the upstream MLIR kernel that was not caught by CI, here's an updated version that uses Snakemake