add python multiset util #291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosseVanDelm
approved these changes
Nov 13, 2024
|
|
||
| def __init__(self, iterable=None): | ||
| """Initialize the multiset with an optional iterable""" | ||
| self.counter = Counter(iterable) if iterable is not None else Counter() |
There was a problem hiding this comment.
This also seems to work, not sure if pyright agrees
Suggested change
| self.counter = Counter(iterable) if iterable is not None else Counter() | |
| self.counter = Counter(iterable) |
|
Is this okay to merge? @jorendumoulin |
|
I'm not 100% sure I will need it after some refactoring, probably I will but I'll let this one sit for a while if that's okay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
functionality for multisets: https://en.wikipedia.org/wiki/Multiset
( a set, where each element has a cardinality (how many times is this element in the set))
I will use this for scheduling tensor operations on accelerators