remove linalg-to-library-call pass (#329)

* remove linalg-to-library-call pass * update pyproject.toml * lockfile
KULeuven-MICAS · Jan 6, 2025 · d663036 · d663036
1 parent 6a1991c
commit d663036
Show file tree

Hide file tree

Showing 10 changed files with 2 additions and 125 deletions.
diff --git a/compiler/tools/snax_opt_main.py b/compiler/tools/snax_opt_main.py
@@ -32,7 +32,6 @@
 from compiler.transforms.fuse_streaming_regions import FuseStreamingRegions
 from compiler.transforms.insert_accfg_op import InsertAccOp
 from compiler.transforms.insert_sync_barrier import InsertSyncBarrier
-from compiler.transforms.linalg_to_library_call import LinalgToLibraryCall
 from compiler.transforms.memref_to_snax import MemrefToSNAX
 from compiler.transforms.realize_memref_casts import RealizeMemrefCastsPass
 from compiler.transforms.reuse_memref_allocs import ReuseMemrefAllocs
@@ -79,7 +78,6 @@ def __init__(
         self.ctx.load_dialect(Debug)
         self.ctx.load_dialect(Stream)
         super().register_pass(DispatchKernels.name, lambda: DispatchKernels)
-        super().register_pass(LinalgToLibraryCall.name, lambda: LinalgToLibraryCall)
         super().register_pass(SetMemorySpace.name, lambda: SetMemorySpace)
         super().register_pass(SetMemoryLayout.name, lambda: SetMemoryLayout)
         super().register_pass(InsertAccOp.name, lambda: InsertAccOp)

diff --git a/compiler/transforms/linalg_to_library_call.py b/compiler/transforms/linalg_to_library_call.py
diff --git a/kernels/alloc/Snakefile b/kernels/alloc/Snakefile
@@ -11,7 +11,6 @@ config["snaxoptflags"] = ",".join(
         "reuse-memref-allocs",
         "insert-sync-barrier",
         "dispatch-regions",
-        "linalg-to-library-call",
         "snax-copy-to-dma",
         "memref-to-snax",
         "snax-to-func",

diff --git a/kernels/simple_copy/Snakefile b/kernels/simple_copy/Snakefile
@@ -10,7 +10,6 @@ config["snaxoptflags"] = ",".join(
         "reuse-memref-allocs",
         "insert-sync-barrier",
         "dispatch-regions",
-        "linalg-to-library-call",
         "snax-copy-to-dma",
         "memref-to-snax",
         "snax-to-func",

diff --git a/kernels/transform_copy/Snakefile b/kernels/transform_copy/Snakefile
@@ -9,7 +9,6 @@ config["snaxoptflags"] = ",".join(
         "realize-memref-casts",
         "reuse-memref-allocs",
         "insert-sync-barrier",
-        "linalg-to-library-call",
         "snax-copy-to-dma",
         "memref-to-snax",
         "snax-to-func",

diff --git a/pixi.lock b/pixi.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -94,7 +94,6 @@ typeCheckingMode = "strict"
     "compiler/transforms/accfg_dedup.py",
     "compiler/transforms/convert_linalg_to_accfg.py",
     "compiler/transforms/frontend/preprocess_mlperf_tiny.py",
-    "compiler/transforms/linalg_to_library_call.py",
     "compiler/transforms/reuse_memref_allocs.py",
     "compiler/transforms/set_memory_layout.py",
     "compiler/transforms/snax_copy_to_dma.py",

diff --git a/runtime/Makefile.rules b/runtime/Makefile.rules
@@ -106,7 +106,7 @@ MLIRPREPROC3FLAGS += --mlir-print-local-scope
 
 # SNAX opt
 
-SNAXOPTFLAGS = -p dispatch-kernels,set-memory-space,set-memory-layout,realize-memref-casts,reuse-memref-allocs,insert-sync-barrier,dispatch-regions,linalg-to-library-call,snax-copy-to-dma,memref-to-snax,snax-to-func,clear-memory-space
+SNAXOPTFLAGS = -p dispatch-kernels,set-memory-space,set-memory-layout,realize-memref-casts,reuse-memref-allocs,insert-sync-barrier,dispatch-regions,snax-copy-to-dma,memref-to-snax,snax-to-func,clear-memory-space
 
 %.snax-opt.mlir: %.preprocfinal.mlir
 	$(SNAXOPT) $(SNAXOPTFLAGS) --print-op-generic -o $@ $<

diff --git a/tests/filecheck/transforms/linalg-to-library-call.mlir b/tests/filecheck/transforms/linalg-to-library-call.mlir
diff --git a/util/snake/configs.py b/util/snake/configs.py
@@ -66,7 +66,6 @@ def get_mlperf_tiny_config():
                     "reuse-memref-allocs",
                     "insert-sync-barrier",
                     "dispatch-regions",
-                    "linalg-to-library-call",
                     "snax-copy-to-dma",
                     "memref-to-snax",
                     "snax-to-func",