resolve pyright issues for access pattern and scheduler (#323)

* resolve pyright issues for access pattern and scheduler

* pixi lockfile

* remove bad test

* add tests

* pixi lockfile

compiler/ir/stream/access_pattern.py

@@ -1,10 +1,10 @@
 from abc import ABC
 from collections.abc import Iterable, Iterator, Sequence
 from dataclasses import dataclass
-from typing import Generic
+from typing import Generic, cast
 
-from typing_extensions import Self, TypeVar, deprecated, overload
-from xdsl.ir.affine import AffineConstantExpr, AffineDimExpr, AffineMap
+from typing_extensions import Self, TypeVar, overload
+from xdsl.ir.affine import AffineConstantExpr, AffineDimExpr, AffineExpr, AffineMap
 
 from compiler.util.canonicalize_affine import canonicalize_map
 
@@ -76,7 +76,7 @@ class SchedulePattern(AccessPattern):
     bounds: tuple[int, ...]
 
     def __init__(self, bounds: Sequence[int], pattern: AffineMap):
-        if any(bound is None or bound <= 0 for bound in bounds):
+        if any(bound <= 0 for bound in bounds):
             raise ValueError(
                 "All bounds must be static, strictly positive integers for a schedule"
             )
@@ -220,10 +220,10 @@ def __iter__(self) -> Iterator[P]:
     def __eq__(self, other: object) -> bool:
         if not isinstance(other, PatternCollection):
             return False
+        other = cast(PatternCollection[P], other)
         return self._patterns == other._patterns
 
     @property
-    @deprecated("only valid in trivial cases")
     def num_dims(self) -> int:
         return self[0].num_dims
 
@@ -244,7 +244,7 @@ def clear_unused_dims(self, bounds: tuple[int] | None = None) -> Self:
         else:
             pattern_bounds = bounds
         unused_dims = tuple(i for i, bound in enumerate(pattern_bounds) if bound == 1)
-        dim_substitutions = []
+        dim_substitutions: list[AffineExpr] = []
         unused_counter = 0
         for dim in range(self.num_dims):
             if dim not in unused_dims:

pyproject.toml

@@ -94,8 +94,6 @@ typeCheckingMode = "strict"
     "compiler/inference/helpers.py",
     "compiler/inference/scoped_setups.py",
     "compiler/inference/trace_acc_state.py",
-    "compiler/ir/stream/access_pattern.py",
-    "compiler/ir/stream/scheduler.py",
     "compiler/ir/tsl/tiled_strided_layout.py",
     "compiler/parser/tsl_parser.py",
     "compiler/transforms/accfg_dedup.py",
@@ -121,7 +119,6 @@ typeCheckingMode = "strict"
     "tests/dialects/test_snax.py",
     "tests/dialects/test_tsl.py",
     "tests/inference/test_accfg_state_tracing.py",
-    "tests/ir/stream/test_access_pattern.py",
     "tests/ir/tsl/test_stride.py",
     "tests/ir/tsl/test_tiled_stride.py",
     "tests/ir/tsl/test_tiled_strided_layout.py",

tests/ir/stream/test_access_pattern.py

@@ -59,7 +59,7 @@ def test_access_pattern_disable_dims():
 
     # test 4: disable 3 dims (all)
     disabled_pattern = access_pattern.disable_dims(3)
-    expected_bounds = tuple()
+    expected_bounds: tuple[int, ...] = tuple()
     expected_results = (
         AffineConstantExpr(0),
         AffineConstantExpr(0),
@@ -87,11 +87,6 @@ def test_schedule_pattern_invalid_bounds():
     pattern = AffineMap(
         num_dims=2, num_symbols=0, results=(AffineDimExpr(0), AffineDimExpr(1))
     )
-    with pytest.raises(
-        ValueError,
-        match="All bounds must be static, strictly positive integers for a schedule",
-    ):
-        SchedulePattern((10, None), pattern)  # pyright: ignore
     with pytest.raises(
         ValueError,
         match="All bounds must be static, strictly positive integers for a schedule",