Add error checking for failed snax-gen make files #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IveanEx do what you told me to do. Try this by removing one config in any cluster config. Then you will see that it terminates early. Unlike without it, the |
|
LOl talk about irony, it really works no because the header files cannot be generated |
2 tasks
|
This PR needs SNAX cluster fix KULeuven-MICAS/snax_cluster#333 |
|
This should work now! |
|
@IveanEx approve?? hehe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional error checking if snax gen fails it terminates the
occamygenas early as possible.The problem arises because it calls a subprocess
make -Cbut even when the make fails, it does not propagate an error toward the occamygen.This PR adds a fix to it.