Fix building on macOS #2341
Merged
Fix building on macOS #2341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Build
|
Still works for me on Ubuntu. 👍 You're compiling on MacOSX? I hope that means you'll submit Mac-related fixes... :) |
|
Got a build environment running today. Expect some updates to the wiki shortly too. :) My free time is limited, but the winforms problem bothers me and I'd like to take a stab at a native UI. |
|
Builds fine under Windows, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks the build script to make it easier to build on macOS.
/usr/bin/sedon macOS is a BSD sed, which was returning successfully with an empty string trying to parse the Cake version out of packages.config, thereby breaking the build. Rather than expect the user to install GNU sed, I've changed the expression to something that should work on both and (at least to me) reads more easily.This branch now builds as-is for me on macOS. I've done minor testing that it's still OK with GNU sed on macOS and changing the build script to use
gsed. I'm hoping CI will catch any other major problems. :)