Compose app tiles from a predetermined list of app Client ID's #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pheyvaer
requested changes
Jul 27, 2022
js/index.js
Outdated
| @@ -45,13 +27,13 @@ async function makeAppTile(app) { | |||
| $div.setAttribute('style', 'width: 13rem'); | |||
|
|
|||
| const $link = document.createElement('a'); | |||
| $link.setAttribute('href', app.link); | |||
| $link.setAttribute('href', app.uri); | |||
| $link.setAttribute('target', '_blank'); | |||
|
|
|||
| const $img = document.createElement('img'); | |||
| $img.setAttribute('class', 'card-img-top p-5'); | |||
| $img.setAttribute('style', 'cursor: pointer'); | |||
There was a problem hiding this comment.
This should be in a separate stylesheet file.
There was a problem hiding this comment.
I moved all the loose styles to a stylesheet in 52ff573
js/apps.js
Outdated
| @@ -0,0 +1,41 @@ | |||
|
|
|||
| // function that will query the necessary data from a Solid app using their ClientID's and the Comunica SPARQL query | |||
There was a problem hiding this comment.
The documentation should like
/**
* Blend two colors together.
* @param {string} color1 - The first color, in hexadecimal format.
* @param {string} color2 - The second color, in hexadecimal format.
* @return {string} The blended color.
*/
Webstorm will add placeholder if you type /**.
There was a problem hiding this comment.
Documentation was updated in 0a39c94
pheyvaer
approved these changes
Jul 28, 2022
|
Fixes #2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.