Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removal of wrong pileup weights function #271

Merged
merged 3 commits into from
Jul 23, 2024
Merged

removal of wrong pileup weights function #271

merged 3 commits into from
Jul 23, 2024

Conversation

nfaltermann
Copy link
Contributor

the version of the function that takes ROOT files as input produces incorrect results.

since we moved to correctionlib there is no need for this to be fixed, thus we can delete it. at least it should not be used in the template analysis anymore.

Copy link
Contributor

@harrypuuter harrypuuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍🏼

@harrypuuter harrypuuter merged commit 8a3e205 into main Jul 23, 2024
7 checks passed
@harrypuuter harrypuuter deleted the pu_removal branch July 23, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants