Skip to content

Commit

Permalink
set C++ 17 and add fmtlib to test container
Browse files Browse the repository at this point in the history
  • Loading branch information
harrypuuter committed Jul 23, 2024
1 parent 9be028c commit 040dd55
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions cmake/AddRoot.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@ if(CMAKE_CXX_COMPILER_ID STREQUAL GNU)
message(STATUS "Attach -fconcepts to the compiler flags to silence warnings.")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fconcepts")
endif()
# require the C++ standard 20 and don't want to fall back to lower
# require the C++ standard 17 and don't want to fall back to lower
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_STANDARD 20)
set(CMAKE_CXX_STANDARD 17)
4 changes: 2 additions & 2 deletions docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ FROM rootproject/root:6.30.04-ubuntu22.04

# Install necessary packages
RUN apt-get update -y
RUN apt-get install -y ca-certificates gpg wget git make python3-pip openmpi-bin libopenmpi-dev libboost-all-dev openssh-client nlohmann-json3-dev
RUN apt-get install -y ca-certificates gpg wget git make python3-pip libfmt-dev openmpi-bin libopenmpi-dev libboost-all-dev openssh-client nlohmann-json3-dev

RUN python3 -m pip install GitPython && python3 -m pip install git+https://github.com/cms-nanoAOD/correctionlib.git

Expand All @@ -20,4 +20,4 @@ RUN cd onnxruntime && ./build.sh --config Release --update --build --build_share
# Install tini
RUN apt-get install -y tini

ENTRYPOINT ["/usr/bin/tini", "--"]
ENTRYPOINT ["/usr/bin/tini", "--"]

0 comments on commit 040dd55

Please sign in to comment.