cxx-qt-lib: Add binding for QQmlApplicationEngine::loadFromModule #1141
Conversation
|
This will fall into the same fallacy as described here: #1140 (comment) due to using QAnyStringView. |
redstrate
force-pushed
the
work/josh/add-loadfrommodule-binding
branch
from
3232bc3 to
88c6b25
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1141 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 71 71
Lines 11967 11967
=========================================
Hits 11967 11967 ☔ View full report in Codecov by Sentry. |
| include!("cxx-qt-lib/qanystringview.h"); | ||
| type QAnyStringView<'a> = crate::QAnyStringView<'a>; |
There was a problem hiding this comment.
you need the cfg flags also here, although unsure if they work on include macros?
As this is a cxx::bridge rather than a cxx_qt::bridge I think the cfg flag should work on an extern block. It's only CXX-Qt bridges where we have the limitation of support only on certain items #1133
There was a problem hiding this comment.
I tried a ton of solutions, and it doesn't seem like extern blocks support cfg macros. It would get rid of the include, but still try to parse the type. I have looked into substituting a dummy type which kinda works, but it's working around missing functionality that should really be in CXX..
redstrate
force-pushed
the
work/josh/add-loadfrommodule-binding
branch
2 times, most recently
from
4cb63ec to
1178956
Compare
This function was added in Qt 6.5, as an alternative from loading files by file path.
redstrate
force-pushed
the
work/josh/add-loadfrommodule-binding
branch
from
1178956 to
6d4dc03
Compare
This function was added in Qt 6.5, as an alternative from loading files by file path.