Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass in the cfg_evaluator to cxx-qt-gen and consider when generating C++ #1133

Open
ahayzen-kdab opened this issue Nov 18, 2024 · 1 comment
Assignees
Labels
🥳🎉 1.0 This issue is part of stabilization for 1.0 release

Comments

@ahayzen-kdab
Copy link
Collaborator

Along with #1132 once we are handling cfg everywhere we need to also ensure that our C++ calls the cfg_evaluator from the build system so that it can determine which headers / source need to be generated.

Otherwise if you have

extern "RustQt" {
   #[qobject]
   type MyObject = ....;

   #[cfg(...)]
   #[cxx_name = "method"]
   fn method_a(&MyObject);

   #[cfg(...)]
   #[cxx_name = "method"]
   fn method_b(&MyObject);
}

This fails as on the C++ side it generates two functions of void method() const noexcept and void method() const.

@ahayzen-kdab
Copy link
Collaborator Author

WIP here #1144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥳🎉 1.0 This issue is part of stabilization for 1.0 release
Projects
Status: ToDo - 0.8
Development

No branches or pull requests

1 participant