-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a notify size for faster acquisition, enabling bulk acquisitions #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in transfer_buffer.py, and made use of it in SpectrumDigitiserCard.get_waveforms()
…in transfer_buffer.py, and made use of it in SpectrumDigitiserCard.get_waveforms()
…ease made without flaky code
…vided as an argument or if no buffer has previously been defined.
crnbaker
force-pushed
the
30_notify_size_no_awg
branch
from
July 20, 2023 19:27
bc81904
to
1332836
Compare
…ersion that doesnt try to communicate with hardware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the "notify size" feature of the driver was not made use of: samples were only read from a transfer buffer after the transfer was complete. Now, samples are read once notification from the driver is received that "notify size" samples have been transferred, so that samples are read out of the transfer buffer while the acquisition is still going on.
This means that waveforms can now be acquired in bulk:
get_waveforms
has a new argumentnum_acquisitions
which specifies the number of acquisitions that should be carried out before the samples are returns. This allows the user to carry out fast software averaging:This branch also includes some more refactoring in preparation for supporting AWGs.
Fixes #30