Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add get_span function on field #91

Merged
merged 3 commits into from
Mar 12, 2021
Merged

Conversation

deng113jie
Copy link
Contributor

closing #86

jie added 2 commits March 11, 2021 16:17
add get_spans() in Field class, similar to get_spans() in Session class
@atbenmurray
Copy link
Member

Can we drop/rethink the comments? Inline comments are stylistically dodgy in general, and I'm not sure that these ones particularly add value. The comments that you added to a couple of the init parameters might be better off as proper docstrings

@deng113jie
Copy link
Contributor Author

removed most of the line comments; left two block comments for use in the future

@atbenmurray atbenmurray merged commit 0aa06b2 into KCL-BMEIS:master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants