fixing unittest errors on windows #222
Conversation
add get_spans() in Field class, similar to get_spans() in Session class
to add CSVDataset file as the import required in module init
…d string, indexed string, etc.
…ction in core.operations. Provide get_spans methods in fields using data attribute.
Modify the get_spans functions in Session to call field method and operation method.
gh-action-pypi-publish works only on linux
.github/workflows/python-app.yml
Outdated
| @@ -23,8 +26,7 @@ jobs: | |||
| - name: Install dependencies | |||
| run: | | |||
| python -m pip install --upgrade pip | |||
| pip install flake8 numpy numba pandas h5py | |||
| if [ -f requirements.txt ]; then pip install -r requirements.txt; fi | |||
| pip install flake8 numpy numba pandas h5py cython | |||
There was a problem hiding this comment.
We should be installing what's in the requirements.txt file so we don't have to change things here if we add more requirements, so just have pip install -r requirements.txt since we know that file is always there.
There was a problem hiding this comment.
ok, I will update that.
| @@ -0,0 +1,8 @@ | |||
| def fib(n): | |||
There was a problem hiding this comment.
Yep, so that the package can be compile. Should be removed later once we have real functions in.
exetera/core/utils.py
Outdated
| @@ -12,7 +12,7 @@ | |||
| import time | |||
| from collections import defaultdict | |||
| import csv | |||
| from datetime import datetime | |||
| from datetime import datetime, timezone, timedelta | |||
There was a problem hiding this comment.
timezone and timedelta unused?
There was a problem hiding this comment.
It seems that we're assuming all datetimes here are always UTC, this will vary from the truth by an hour at times when daylight savings is relevant, but so long as that's systematic always across platforms that's fine for our purposes. Just a few things I mentioned
main type of errors:
solution: add timezone to datetime
solution: change dict key to bytes if is string
solution: change type to int64
4)one minor issue in categorical field values
Also added workflow files for macos & windows
Added a example cython file to test the compile workflow