4.8.16 dev #4
Open
4.8.16 dev #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* user search facets patch (sunbird-cb#70) * 4.8.15 dev v1 (sunbird-cb#71) * user search facets patch * user search facets patch * 4.8.15 dev v1 (sunbird-cb#72) * user search facets patch * user search facets patch * user search facets patch * user search facets patch * 4.8.15 dev v1 (sunbird-cb#73) * user search facets patch * user search facets patch * user search facets patch * user search facets patch * user search facets patch * user search facets patch * kafka topic after user profile update * logger added --------- Co-authored-by: anilkumarkammalapalli <[email protected]>
* user search facets patch (sunbird-cb#70) * 4.8.15 dev v1 (sunbird-cb#71) * user search facets patch * user search facets patch * 4.8.15 dev v1 (sunbird-cb#72) * user search facets patch * user search facets patch * user search facets patch * user search facets patch * 4.8.15 dev v1 (sunbird-cb#73) * user search facets patch * user search facets patch * user search facets patch * user search facets patch * user search facets patch * user search facets patch * kafka topic after user profile update * logger added * mentoring topic data updated --------- Co-authored-by: anilkumarkammalapalli <[email protected]>
* user search facets patch (sunbird-cb#70) * 4.8.15 dev v1 (sunbird-cb#71) * user search facets patch * user search facets patch * 4.8.15 dev v1 (sunbird-cb#72) * user search facets patch * user search facets patch * user search facets patch * user search facets patch * 4.8.15 dev v1 (sunbird-cb#73) * user search facets patch * user search facets patch * user search facets patch * user search facets patch * user search facets patch * user search facets patch * kafka topic after user profile update * logger added * mentoring topic data updated * mentor roels added in user private read * added constants --------- Co-authored-by: anilkumarkammalapalli <[email protected]>
* user search facets patch (sunbird-cb#70) * 4.8.15 dev v1 (sunbird-cb#71) * user search facets patch * user search facets patch * 4.8.15 dev v1 (sunbird-cb#72) * user search facets patch * user search facets patch * user search facets patch * user search facets patch * 4.8.15 dev v1 (sunbird-cb#73) * user search facets patch * user search facets patch * user search facets patch * user search facets patch * user search facets patch * user search facets patch * kafka topic after user profile update * logger added * mentoring topic data updated * mentor roels added in user private read * added constants * added role insied mentoring map --------- Co-authored-by: anilkumarkammalapalli <[email protected]>
* user search facets patch (sunbird-cb#70) * 4.8.15 dev v1 (sunbird-cb#71) * user search facets patch * user search facets patch * 4.8.15 dev v1 (sunbird-cb#72) * user search facets patch * user search facets patch * user search facets patch * user search facets patch * 4.8.15 dev v1 (sunbird-cb#73) * user search facets patch * user search facets patch * user search facets patch * user search facets patch * user search facets patch * user search facets patch * kafka topic after user profile update * logger added * mentoring topic data updated * mentor roels added in user private read * added constants * added role insied mentoring map * bug fix for v5 user read --------- Co-authored-by: anilkumarkammalapalli <[email protected]>
Sahil-tarento
requested changes
Aug 7, 2024
| if (result.get(JsonKey.ROLES) instanceof List) { | ||
| List<?> list = (List<?>) result.get(JsonKey.ROLES); | ||
|
|
||
| if (!list.isEmpty() && list.get(0) instanceof HashMap) { |
There was a problem hiding this comment.
Please handle null pointer and try to use collectionUtils as it handle the proper null pointer
| userDetails.put(JsonKey.USER_ID,user.getUserId()); | ||
| InstructionEventGenerator.mentorshipUserUpdateEvent("", topic, userDetails); | ||
| logger.info("kafka_mentorship_user_update_topic event pushed"); | ||
| }catch (Exception e){ |
| InstructionEventGenerator.mentorshipUserUpdateEvent("", topic, userDetails); | ||
| logger.info("kafka_mentorship_user_update_topic event pushed"); | ||
| }catch (Exception e){ | ||
| logger.info("error while generating mentorship event"); |
There was a problem hiding this comment.
The error should give proper msg and it should be error
| roles.add((String) hashmap.get(JsonKey.ROLE)); | ||
| } | ||
| } | ||
| } else if (!list.isEmpty() && list.get(0) instanceof String) { |
There was a problem hiding this comment.
Please handle null pointer and try to use collectionUtils as it handle the proper null pointer
| Collections.singletonMap(JsonKey.USERID, ids), | ||
| Arrays.asList(JsonKey.ROLE, JsonKey.USERID), context); | ||
|
|
||
| ((List<Map<String, Object>>) cassandraResponse.getResult().get(JsonKey.RESPONSE)).stream() |
| .add((String) userRole.get(JsonKey.ROLE)) | ||
| ); | ||
|
|
||
| ((List<Map<String, Object>>) response.getResult().get(JsonKey.RESPONSE)).stream() |
There was a problem hiding this comment.
Why you do typecast of not assign to any variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.