Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mellanox] Fix issues found for CMIS host management #210

Closed
wants to merge 1 commit into from
Closed

[Mellanox] Fix issues found for CMIS host management #210

wants to merge 1 commit into from

Conversation

Junchao-Mellanox
Copy link
Owner

@Junchao-Mellanox Junchao-Mellanox commented Dec 15, 2023 •
edited
Loading

Why I did it

  1. thermal updater should wait more time for module to be initialized
  2. sfp should get temperature threshold from EEPROM because SDK sysfs is not yet supported
  3. rename sfp function to fix typo
  4. sfp.get_presence should return False if module is under initialization
Work item tracking
  • Microsoft ADO (number only):

How I did it

  1. thermal updater should wait more time for module to be initialized
  2. sfp should get temperature threshold from EEPROM because SDK sysfs is not yet supported
  3. rename sfp function to fix typo
  4. sfp.get_presence should return False if module is under initialization

How to verify it

Manual test
Unit test

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202311

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@Junchao-Mellanox Junchao-Mellanox changed the base branch from master to 202305 December 15, 2023 03:36
@Junchao-Mellanox Junchao-Mellanox changed the base branch from 202305 to master December 15, 2023 03:36
@Junchao-Mellanox Junchao-Mellanox changed the title Junchao: enlarge wait time in thermal updater [Mellanox] enlarge wait time in thermal updater Dec 15, 2023
@Junchao-Mellanox Junchao-Mellanox force-pushed the master-fix-thermal-updater branch 3 times, most recently from 78eb5d5 to 42d1db0 Compare December 26, 2023 10:33
@Junchao-Mellanox Junchao-Mellanox changed the base branch from master to 201709 December 26, 2023 10:34
@Junchao-Mellanox Junchao-Mellanox changed the base branch from 201709 to master December 26, 2023 10:34
@Junchao-Mellanox Junchao-Mellanox changed the title [Mellanox] enlarge wait time in thermal updater [Mellanox] Fix issues found for CMIS host management Dec 26, 2023
@Junchao-Mellanox Junchao-Mellanox force-pushed the master-fix-thermal-updater branch 4 times, most recently from bcdf43a to 329fa27 Compare December 27, 2023 05:55
@Junchao-Mellanox
Copy link
Owner Author

CI 3423 passed

@Junchao-Mellanox Junchao-Mellanox deleted the master-fix-thermal-updater branch January 19, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keboliu keboliu keboliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Junchao-Mellanox @keboliu