Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layouts/latn_bone.xml: improve #760

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

quantenzitrone
Copy link
Contributor

@quantenzitrone quantenzitrone commented Sep 21, 2024

new syntax: n/s/e/w/ne/nw/se/sw instead of key{1..8}

Some keys were missing keys according to the tests, this adds them similarly to latn_neo2.
Only switch_backward didn't fit (because of the 0 at the bottom of the spacebar).

I also added a \ in front of the @, not sure if that is necessary, but it is part of the escape character documentation.

@quantenzitrone quantenzitrone changed the title bone layout: use new syntax and add most missing layouts/latn_bone.xml: use new syntax and add most missing Sep 21, 2024
@quantenzitrone quantenzitrone changed the title layouts/latn_bone.xml: use new syntax and add most missing layouts/latn_bone.xml: use new syntax and add most missing keys Sep 21, 2024
Copy link
Owner

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

switch_backward and switch_forward are extremely important keys as they allow between layouts.
The bottom row is similar to the default one except for some keys added in this PR. To avoid maintaining this in the future and missing new features, what do you think of removing the custom bottom row in this layout ? The cost is to move 0 elsewhere.

@quantenzitrone
Copy link
Contributor Author

I've always been switching keyboard with change_method in the upper right of the Fn key.

@quantenzitrone
Copy link
Contributor Author

Oh I realize its for switching the internal layout.
Gonna fix this later.
At least switch_forward should be on the space bar.

new syntax: n/s/e/w/ne/nw/se/sw instead of key{1..8}

Some keys were missing keys according to the tests, this adds them in a
similar way to latn_neo2.
Only `switch_forward` didn't fit (because of the 0
at the bottom of the spacebar).
@quantenzitrone
Copy link
Contributor Author

Ok now only switch_backward is missing.
Which may be annoying if you have more than 2 different keyboard layouts to switch between.
But switching is possible.

I could put the 0 on se like the other numbers, but I think it should remain on space.
I think I had problems with corner keys on the spacebar due to the length, but I could try it.

@quantenzitrone
Copy link
Contributor Author

I have an idea.
Is it be possible to combine accent_circonflex and superscript with a modmap?

@quantenzitrone quantenzitrone marked this pull request as draft September 22, 2024 22:34
@quantenzitrone
Copy link
Contributor Author

Do we have these diacritical marks?
https://en.wikipedia.org/wiki/Rough_breathing
https://en.wikipedia.org/wiki/Smooth_breathing
I have no idea why neo people put these on the bone layout. They are probably not needed, especially not on the latin layer.

@Julow
Copy link
Owner

Julow commented Sep 23, 2024

I could put the 0 on se like the other numbers, but I think it should remain on space.

That means having to maintain the layout more often and having inconsistent placement for important keys.

Is it be possible to combine accent_circonflex and superscript with a modmap?

That's currently only possible by modifying the app to add this combinaison as a new diacritic.

Do we have these diacritical marks?

We don't have Rough and Smooth breathing I believe but they could be added if necessary.

- use number row to unclutter rest of keyboard
- use modmap for special shift functions of bone layout
- add missing loc characters
- use standard bottom bar
- add diacritics from the 3 dead key keys on bone
- 2 small keys left and right of the number row (don't fit all 6
  diacritics, so they leak onto the number keys)
- row 1 is full too, so the dead keys from the left of that row leak
  onto the keys there as well

open questions:
- should bone rely on the math layer or use modmap?
- possibility to combine diacritics?
@quantenzitrone
Copy link
Contributor Author

Nah I think rough and smooth breathing are not necessary.
Not even computer neo layouts have a use for rough breathing, according to the documentation the key is completely useless.

@quantenzitrone quantenzitrone marked this pull request as ready for review September 23, 2024 22:11
@quantenzitrone quantenzitrone changed the title layouts/latn_bone.xml: use new syntax and add most missing keys layouts/latn_bone.xml: improve Sep 23, 2024
@quantenzitrone
Copy link
Contributor Author

Would you accept if I add neo specific modifiers (diacritics)?
They could be used for neo2 and bone as well as other neo variants that may be added in the future: neoqwert{z,y}, mine, noted.
While they are not super needed, they are a neat feature of neo layouts.
https://www.neo-layout.org/Benutzerhandbuch/Tote-Tasten-und-Compose/#erzeugbare-zeichen-mit-den-toten-tasten (docs in german)

@Julow
Copy link
Owner

Julow commented Sep 23, 2024

Adding neo specific diacritics and compose sequences to the app is fine! It's possible to add a new compose key that is either a pre-applied sequence or an entirely different set of sequences.

@quantenzitrone
Copy link
Contributor Author

If you want, you can merge this like this.
I'm currently working on improving (completing) the current diacritics modifiers, so I can combine some of them in the way neo does it for the neo specific modifiers.
I opened another pr #770 because it got out of scope of this pr.

Copy link
Owner

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The layout is extremely busy and the extra row makes it hard to read. Are you sure you need all these symbols on the main layer ?
Many of these are already on the Fn layer or in compose sequences. For even more symbols, I'd suggest you to make a second custom layout dedicated to rarely used symbols.

Comment on lines +11 to +12
<shift a="4" b="»"/>
<shift a="5" b="«"/>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are already Fn+< and Fn+>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah the fn mapping conflicts with neo layouts,
i was considering removing it or completely mod-remapping it for some other purpose

Comment on lines +15 to +17
<shift a="8" b="„"/>
<shift a="9" b="“"/>
<shift a="0" b="”"/>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are already Fn+", Fn+( and Fn+) respectively.

<row>
<!--left side-->
<key width="0.5" key0="loc accent_circonflexe" nw="superscript"/>
<key key0="1" ne="¹" se="₁" nw="loc accent_caron" n="subscript"/>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

, , and are already accessible with subscript, which is also present on the layout.
Same for the superscripts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think they were put there because ¹²³₁₂₂₀ are used more frequently that all the other numbers

<key key0="4" ne="›" se="♀" nw="loc accent_hook_above" n="loc accent_horn"/>
<key key0="5" ne="‹" se="♂" nw="loc accent_dot_below"/>
<!--right side-->
<key key0="6" nw="¢" sw="⚥" ne="loc accent_macron"/>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¢ is already Fn+c and ¥ is Fn+y

<key key0="2" ne="²" se="₂" nw="↻"/>
<key key0="3" ne="³" se="₃" nw="loc accent_dot_above"/>
<key key0="4" ne="›" se="♀" nw="loc accent_hook_above" n="loc accent_horn"/>
<key key0="5" ne="‹" se="♂" nw="loc accent_dot_below"/>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and are already on the keyboard as Fn+{ and Fn+}

<key key0="1" ne="¹" se="₁" nw="loc accent_caron" n="subscript"/>
<key key0="2" ne="²" se="₂" nw="↻"/>
<key key0="3" ne="³" se="₃" nw="loc accent_dot_above"/>
<key key0="4" ne="›" se="♀" nw="loc accent_hook_above" n="loc accent_horn"/>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you use symbols like , , and so often that you need them on the main layout ? I'd suggest creating compose sequences for these.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really but i just wanted to make it more close to the original
i don't think it hurts to include them
Furthermore, neo layouts use ↻ in compose sequences for rotating characters. e.g. Compose ↻ r becomes ɹ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants